model/...: remove error parameter from decoders #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is non-idiomatic, unused, and promotes a code pattern which leads to unnecessary CPU cycles.
Codecov Report
@@ Coverage Diff @@
## master #3571 +/- ##
==========================================
- Coverage 79.31% 79.23% -0.08%
==========================================
Files 110 110
Lines 5873 5865 -8
==========================================
- Hits 4658 4647 -11
- Misses 1215 1218 +3
|
jalvz
approved these changes
Mar 30, 2020
axw
added a commit
to axw/apm-server
that referenced
this pull request
Apr 8, 2020
This is non-idiomatic, unused, and promotes a code pattern which leads to unnecessary CPU cycles.
axw
added a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Remove the input error parameter from the top-level model types' Decode functions. This is a non-idiomatic pattern which leads to less than ideal performance due to repeatedly checking errors rather than the idiomatic approach of checking once and bailing out early. The input error is always nil in practice for the modified decoders.
I've left the other decoders alone for now, as that's a much bigger change. We should address those as part of #3551.
Checklist
make check-fullfor static code checks and linting)- [ ] I have made corresponding changes to the documentation- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have updated CHANGELOG.asciidocHow to test these changes
make testRelated issues
None